Question: (onFullSupported "nixos.tests.keymap.dvorak") (onFullSupported "nixos.tests.keymap.dvorak-programmer") (onFullSupported "nixos.tests.keymap.neo") <del> (onFullSupported "nixos.tests.keymap.qwertz") </del> <ins> (onSystems ["x86_64-linux"] "nixos.tests.keymap.qwertz") </ins> (onFullSupported "nixos.tests.latestKernel.login") (onFullSupported "nixos.tests.lightdm") (onFullSupported "nixos.tests.login")

In combination with 21.11 adding it to the job, this prevents channel. The keymap tests don't have any maintainers. That's quite an issue for channel-blocking jobs, I think.
Well, we could remove from the blocking set, at least for now. It certainly doesn't feel so critical to me. (Though qwertz layout gets vast majority in my country actually.)
In it was discussed wether Linux 5.15 could be the cause, but the way I see it the test is running with Linux 5.10? 5.15 seems only to be used for the stdenv.
Yes, It is at least surprising that a large part of the channel tests is about keyboard layouts.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
if the keymap tests have no maintainers, perhaps they should be removed, or at leat disabled for now.
it looks like its random which one symbol fails azerty fails sometimes too
This test has been flaky since and does not provide much value. I propose to simply remove it from the tested job.
I'm thinking this is a race condition with sending keys too fast, maybe made worse when a builder is under high load. Something like this perhaps?
EDIT: it takes way too long to run the test without kvm so i didn't i'll run the test with and without that. and with running to mimic high load i had to apply this patch to run the test vm because kvm was failing but its very very slow now
So, at least the simple step for now?
the sleep patch does indeed fix the issue, at least when building on my Honeycomb. I do think it's odd though that the test fails in exactly the same way every time I run it. I'd expect it to fail less consistently, or in different ways…
azerty test fails sometimes too
While it's far from elegant, I'd be fine with adding the sleep patch. Since it's only 10ms per character, I don't think the performance impact will be significant, and I'd prefer to start verifying the functionality again (major use case: encryption passphrase input, where the results aren't even visible).


Question: (onFullSupported "nixos.tests.keymap.dvorak") (onFullSupported "nixos.tests.keymap.dvorak-programmer") (onFullSupported "nixos.tests.keymap.neo") <del> (onFullSupported "nixos.tests.keymap.qwertz") </del> <ins> (onSystems ["x86_64-linux"] "nixos.tests.keymap.qwertz") </ins> (onFullSupported "nixos.tests.latestKernel.login") (onFullSupported "nixos.tests.lightdm") (onFullSupported "nixos.tests.login")

i've run some tests on my rpi4b and found that applying this patch fixes the issue even with load and no delay(i still think we should leave the delay) <pre<del0.02 sometimes works if there is no other load at least 0.04 is needed to sometimes not fail when i run 1 is safe according to this the average inter-key interval of a human is 238ms INTER-KEY INTERVALS Average inter-key interval is 238.656 ms (SD = 111.6). A lower bound of about 60 ms can be observed.</del</pre


Question: , at-spi2-core , libXtst <del> , swig </del> <ins> , swig4 </ins> , python , wxPython , opencascade-occt

Steps to reproduce the behavior: kicad (tested on ) The relevant part of the build log is: Complete build log is here: Setting the flag in the cmake build flags, solves the issue. Please run and paste the result.
thanks for filing an issue i'm not sure what changed to cause this issue, or why that change didn't notify me of the breakage... i'll try to get your fix or something similar in a PR today


Question: # around it, we force the path to the cfgFile. # # https://github.com/NixOS/nixpkgs/issues/121088 <del> serviceConfig.ExecStart = [ "" "${getBin package}/bin/pcscd -f -x -c ${cfgFile}" ]; </del> <ins> serviceConfig.ExecStart = [ "" "${package}/bin/pcscd -f -x -c ${cfgFile}" ]; </ins> }; }; }

uses two actions and do get necessary authorization via . but these actions are not properly registed, leading to error: (It can be verified that these actions don't exist by using ) This breaks and . I tried both pcsclite 1.9.5 and 2.0.1 ending up with the same error. Steps to reproduce the behavior: and in , configure your smartcard (yubikey) to use yubikey error There actions are registered correctly and usable. Please run and paste the result. I'm using flakes (no channels). Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
correct description of your effect, i am not able to use my yubikey with gpg.
This can be solved by
this works, thanks! but this is really unintuitive, given that is already adding the package to : I am leaving this open as I believe a proper fix should be provided in the module itself.
Same issue here. It was working approx. last Dec. I don't have a specific commit hash. Adding to works for me.
Looks like a regression in () - is implying to me that polkit actions get included in the output, however: isn't included, which explains why adding to fixes the issue. Solution ideas: Add to . Not sure about this one? seems to also contain some libraries that probably don't need to be installed. Install polkit actions to instead of . IMO this one makes the most sense, especially as it seems to have been the previous behaviour before this change.
I was bitten by this when attempting to update over the weekend as well. In my case it prevented login because I use smartcards for user login which made debugging difficult due to the number of reboots required. I tend to agree with that going back to having the polkit actions file in the output instead of makes the most sense. That will mean that of the pcsc module will again result in the polkit action file being to the system configuration.
Cc: ()
I also think the location should be fine, the files are also there.
I ran into this issue when I couldn't access my yubikey anymore via pcsc for commits. The above solution worked for me.


Question: # around it, we force the path to the cfgFile. # # https://github.com/NixOS/nixpkgs/issues/121088 <del> serviceConfig.ExecStart = [ "" "${getBin package}/bin/pcscd -f -x -c ${cfgFile}" ]; </del> <ins> serviceConfig.ExecStart = [ "" "${package}/bin/pcscd -f -x -c ${cfgFile}" ]; </ins> }; }; }

I'm going to add some comments for SEO so this is easier to find
I think you have found the right culprit that caused the issue, but I suppose the issue has more to do with the itself, where it only includes if . This has been rectified in from what it seems. For now the proper solution seems to enabling polkit with .
I think that makes more sense based on the existing file structure but maybe we just switch bin to out, so it is the default and move the libs to lib instead of being in out.
I've created to make the outputs a lot more expected by moving the udev file and the systemd service to the out output and the libraries to the lib output: I didn't test it yet, so it is still in draft. If someone could verify that it doesn't break security keys again, that would be great and then please undraft it, otherwise I do it in the evening.
I do not think I can fully test this due to the amount of rebuilds, so please chime in for reviews and find the one mistake I might have done (which I hope I didn't)
Tried to build but it fails on my machine:
I've xdist to dulwich here . Let me see if we can just disable some tests as a speed up from 66s to 9s is quite good.
This should be a lot better with . I did a lot of rebuilds locally on a low and high core machine and didn't encounter any failures anymore.
This was fixed in , works fine for me.


Question: ''; nativeBuildInputs = [ autoreconfHook pkg-config ] <del> ++ lib.optional qtClient [ qt5.wrapQtAppsHook ]; </del> <ins> ++ lib.optional qtClient [ qt5.wrapQtAppsHook ] ++ lib.optional gtkClient [ wrapGAppsHook ]; </ins> buildInputs = [ lua5_3 zlib bzip2 curl xz gettext libiconv ] ++ lib.optionals sdlClient [ SDL SDL_mixer SDL_image SDL_ttf SDL_gfx freetype fluidsynth ]

should provide a QT client to freeciv, which is probably named if I had to guess. Steps to reproduce the behavior: only gtk client installed (see below) A executable. If applicable, add screenshots to help explain your problem. ! -( does not exist) ! The installed is indeed a gtk client. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (You were the last person to commit, so I choose you :) ) (I don't believe the listed maintainer exists). Please run and paste the result. Maintainer information:


Question: <del> { lib, stdenv, fetchurl </del> <ins> { lib, stdenv, fetchurl, makeWrapper </ins> , pkg-config, intltool , perl, gettext, libX11, libXext, libXi, libXt , libXft, libXinerama, libXrandr, libXxf86vm, libGL, libGLU, gle , gtk2, gdk-pixbuf, gdk-pixbuf-xlib, libxml2, pam <del> , systemd </del> <ins> , systemd, coreutils </ins> , forceInstallAllHacks ? false , withSystemd ? stdenv.isLinux }:

Since commit the command is missing. It is used by xscreensaver to display text inside the screensavers like system information and kernel versions. It used to be in the package, as can be seen from this diff: The same applies to which was also removed by that commit Steps to reproduce the behavior: Text is printed when running instead of If applicable, add screenshots to help explain your problem. Add any other context about the problem here. system: host os: multi-user?: sandbox: version: channels(root): channels(pinpox): nixpkgs: Maintainer information:
«removed» here means «same lack of special measures as before» (the lines you cite are just fixes for the installed stuff), but upstream underwent a major rewrite. (Not saying that fix is not most welcome, just that this was not a removal as much as lack of finding out what to do now) Apparently the scripts are there in the tarball, maybe they need manual copying now, not sure
I just noticed it seems to work fine in the previewer application that comes with xscreensaver . E.g.: ! The same screensaver does not work though, when it starts "on it's own" after some idle time. The text then only reads Not sure what the difference is.
xscreensaver-text and others are in $out/libexec/xscreensaver btw speeds up the build of xscreensaver by a lot
Hm, is not in my path, but hacks launched via XScreenSaver proper find text just fine. And the daemon source code implies that is indeed to PATH in a normal situation.
Not sure if it's related, but it is also missing commands like and (output is shown in some of the screensavers). I have enabled xsceensaver with the home-manager option


Question: buildGoPackage rec { pname = "singularity"; <del> version = "3.2.1"; </del> <ins> version = "3.6.1"; </ins> <del> src = fetchFromGitHub { owner = "sylabs"; repo = "singularity"; rev = "v${version}"; sha256 = "14lhxwy21s7q081x7kbnvkjsbxgsg2f181qlzmlxcn6n7gfav3kj"; </del> <ins> src = fetchurl { url = "https://github.com/hpcng/singularity/releases/download/v${version}/singularity-${version}.tar.gz"; sha256 = "070jj6kbiw23sd2p4xhvmyb8gd83imwgisdf18ahkwp7dq85db3c"; </ins> }; goPackagePath = "github.com/sylabs/singularity"; goDeps = ./deps.nix; <del> buildInputs = [ openssl ]; nativeBuildInputs = [ removeReferencesTo utillinux which makeWrapper ]; </del> <ins> buildInputs = [ gpgme openssl libuuid ]; nativeBuildInputs = [ removeReferencesTo utillinux which makeWrapper cryptsetup ]; </ins> propagatedBuildInputs = [ coreutils squashfsTools ]; <del> prePatch = '' substituteInPlace internal/pkg/build/copy/copy.go  </del> <ins> postPatch = '' substituteInPlace internal/pkg/build/files/copy.go  </ins> --replace /bin/cp ${coreutils}/bin/cp '';

, CVSSv3=7.5 (nixos-20.03) CVSSv3=7.5 (nixos-20.03) Scanned versions: nixos-20.03: . May contain false positives. Cc Cc Cc
Backporting update that resolves these ().
Fixed in 20.03 and master.


Question: push @kernelModules, "kvm-intel" if hasCPUFeature "vmx"; push @kernelModules, "kvm-amd" if hasCPUFeature "svm"; <ins> push @attrs, "hardware.cpu.amd.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "AuthenticAMD"; push @attrs, "hardware.cpu.intel.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "GenuineIntel"; </ins> # Look at the PCI devices and add necessary modules.  Note that most # modules are auto-detected so we don't need to list them here.

It would be nice if generated and options (only ). Processors without microcode update might run with misbehaving flashed microcode: /cc
Do you mean like setting it to or just mentioning it? It's a good thing for sure to have working hardware as opposed to not working, but OTOH it pulls non free code...
Of course setting it to true (actually to ), mentioning it would have no effect. First, already pulls in literal unfree code, e.g. Wi-Fi drivers on MacBook Air 6,x, not even redistributable. Second, non-free code is already running on Intel processors, I don't see any difference whether it's flashed or not (I know this is controversial). Third, for purposes of Nixpkgs, is free. And of course the kernel contains a whole lot of firmware blobs.
Strongly disagree here as its an equivalent of setting = true; thus will taint every installation by default, which is a reverse policy of the current nixos from optin to optout. That said, being complete new user, I have myself figured and found these options myself. My system booted without them likewise fine. In general, AMD patches CPUs with AGEISA BIOS updates, so does Intel - however these updates are optional and up to the user. This is should be mentioned on a) Installation page b) NIxos wiki - not be made default option, because this action is in conflict with policy.
I disagree that this is equivalent. CPU comes preflashed with microcode, BIOS comes with updated microcode for the processor to boot correctly (microcode that comes with CPU is very buggy and usually can't go through boot sequence correctly). It's not clear how it would add to the problem if we were to load an up-to-date microcode image. This is equivalent to shipping firmware to users that haven't set flag, which is current NixOS policy. Intel microcode is freely redistributable AFAIK.
The default state for these two switches is very clearly "disabled", plus they have no affect on non-AMD/intel CPUs. Flipping the switch in hardware-, is basically flipping the default state in the backstage, which is much worse than setting the defaults to "enabled", as it creates distrust and inconsistency cases. Further, firmware updates can cause real issues, not only solve them.


Question: push @kernelModules, "kvm-intel" if hasCPUFeature "vmx"; push @kernelModules, "kvm-amd" if hasCPUFeature "svm"; <ins> push @attrs, "hardware.cpu.amd.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "AuthenticAMD"; push @attrs, "hardware.cpu.intel.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "GenuineIntel"; </ins> # Look at the PCI devices and add necessary modules.  Note that most # modules are auto-detected so we don't need to list them here.

It is irresponsible to think that they only solve issues. AMD AGEISA updates on 785G on has actually been broken for over a year for me, refusing to react to USB events on boot until I manually bypassed the tier 1&2 support (which is hell of a job for Linux user) to get to actual support for testing. About Intel, I have only encountered issues with gen3 PCIe cards in Intel motherboard for 2nd gen Core CPUs, but fixing this also required a year of waiting and UEFI reflash. Also speaking as an owner of HP() and Epson(sx525wd) printers - updating ucode actually caused hardware reflash and made legally purchased cartridges worthless. I am yet to encounter a CPU that can't pass boot sequence due to buggy ucode, but I doubt hot-loading it on OS stage would fix it, because it needs first to get to this stage. However I can clearly imagine the unpredictability if these switches are properly enabled.
Microcode is essentially a firmware for the CPU. NixOS, more specifically, the Linux kernel, will load firmwares for any device with support for that without asking the user. Loading microcode updates does not require a policy change, if anything, this would make the policy more consistent across the board. On a tangent, I don't understand why anyone would tolerate a blob flashed on CPU, and in BIOS, but would not tolerate the same blob being loaded by the kernel. That can be said about any software. Usually, the opposite is true. What I mean is that every BIOS except Libreboot contains microcode blobs that it loads onto the processor early in the boot sequence. Without that blob, boot sequence will most likely fail somewhere along the way. That's the reason why Libreboot doesn't support modern Intel/AMD CPUs, and why there is Coreboot/Libreboot split in the first place.
You are mixing very different cases into one bottle. Some hardware requires ucode to be loaded to function and won't function without. Some hardware has optional ucode updates. For this hardware, some classes load firmware update and then flash themselves - some lock the possibility to install previous revision, and some classes load the ucode as temporary override (which is case with AMD/Intel). Some hardware has open firmware (sources), but majority does not offer source.


Question: push @kernelModules, "kvm-intel" if hasCPUFeature "vmx"; push @kernelModules, "kvm-amd" if hasCPUFeature "svm"; <ins> push @attrs, "hardware.cpu.amd.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "AuthenticAMD"; push @attrs, "hardware.cpu.intel.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "GenuineIntel"; </ins> # Look at the PCI devices and add necessary modules.  Note that most # modules are auto-detected so we don't need to list them here.

In essence, ucode is a blackbox and live-updating ucode is unpredictable black box. For some devices, ucode loading is a must, for others its optional. I suggest that we limit ourselves to specific case of Intel/AMD ucode, for which ucode updates are optional and crucial updates are applied only via hardware flashing. I am pretty sure that the reason why Libreboot supports less hardware has to do purely with acceptance criteria for how tainted ("blackboxed") the firmware is, and that both support little of x86, because Intel refused to provide specifications and AMD was open to some extent, but then closed up the AGESA after Phenom II because they most possibly implemented TPM in firmware(fTPM). About EULA-d + encrypted software, we are talking about closed-source hardware. For manufacturers of such software, surely opposite is true and the updates are usually used to keep their policy consistent and enforced, for users it means giving up and restricting all rights. That said, I found those options myself easily as a new user (yet my hardware functioned without issues without them) and I see a problem if they default to one value, but change "automatically" and unnoticed at run-time. Either way, this option should be documented better - and this includes places where its flipped.
It's not clear what difference does it make. Say, from freedom perspective, it would not be OK to use Windows even if I were to ignore any updates for it. If we ship updated microcode, which includes security fixes foremost, how would that taint installs any more than they currently are, with in-kernel blobs and such?
It has to do with blobs for the most part. See:
It replaces non-free code with a more up2date non-free code. Given Meltdown and Spectre this should be the default. Especially since it would be generated at installation time. Accompanied with the right comment, users who really want to have outdated CPUs will be notified and can delete one line. (well two with the comment).
I would like this to default to (microcode essentially is firmware). isn't supposed to be edited, it should just use so that user can override it in their config.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days.


Question: push @kernelModules, "kvm-intel" if hasCPUFeature "vmx"; push @kernelModules, "kvm-amd" if hasCPUFeature "svm"; <ins> push @attrs, "hardware.cpu.amd.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "AuthenticAMD"; push @attrs, "hardware.cpu.intel.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;" if cpuManufacturer "GenuineIntel"; </ins> # Look at the PCI devices and add necessary modules.  Note that most # modules are auto-detected so we don't need to list them here.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
still think this should be done, as new users probably don't know this option exists at all and that you have to enable it by yourself in NixOS. With concerns on, this should at least be generated as commented out, with a hint "while you will probably want this, note that it is unfree software".
I marked this as stale due to inactivity. →
Why is this no longer in discussion? As someone new to the NixOS universe and coming from Ubuntu I wasn't aware that I had to explicitely include this in my hardware configuration on NixOS until I stumbled across other people's configuration files. I definitely think it should at least be prominently featured in the installation manual or even better be enabled by default, as mentioned.
One way or another, needs to be enabled by default. These updates fix security issues, there are probably a lot of NixOS users now that don't even know that they're running insecure microcode. See also the discussion in
I've never replied to the first comment! While I still support the open hardware movement (and thus free software firmware) I also believe that having QEMU misbehave because of a missing update is not really a good default option. If the user is concerned about the microcode updates or about managing security at this level then they will probably read the auto-generated configuration and immediately spot an and will comment it out :-) So thanks for the PR, I can't review because I don't know perl :-p


Question: Use `lib.mkForce` to forcefully specify the overridden package. ''; }; <ins> enableExternalLocalStateDir = mkOption { type = types.bool; default = true; example = false; description = mdDoc '' Whether to use top-level directories as LOCALSTATEDIR instead of the store path ones. This affects the SESSIONDIR of Apptainer/Singularity. If set to true, the SESSIONDIR will become `/var/lib/''${projectName}/mnt/session`. ''; }; </ins> enableFakeroot = mkOption { type = types.bool; default = true;

The derivation is missing the directory to work properly. Steps to reproduce the behavior: A clear and concise description of what you expected to happen. is output without error. This can be fixed by creating the directory manually (). I guess this could be to the derivation. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
NixOS module provides those top-level directories. discussed with one of the main Apptainer developer in . He think it should be easy to specify a directory that will always exist at build time. Regalding this, I'm considering the possibility to put those dilectories under the derivation store path. Not sure if there would be potential problem using a store path as a mount point, but it seems to work without problem.
Could you help me take a look at ?
If you have time, please help me test the PR . It should fundamentally solve this issue. If applied, you no longer need the NixOS module or just to run images. It specifies the LOCALSTATEDIR as , making both Apptainer and Sylabs SingularityCE works without . (The image running still depends on and to run images, which might be the final obstacle to build images as a package without invoking a virtual machine. Other than that, it should not be an issue for most users, as are available on most of the UNIX/UNIX-like systems.)
I removed (the temporary fix for this issue) and ran the following and it seems to work fine: Thank you for this fix!
Glad to hear that! Would you mind ? I've heard that committers tend to merge PRs getting two approvals.
Done!


Question: then "localSystem" else "crossSystem"} = { parsed = makeMuslParsedPlatform stdenv.hostPlatform.parsed; }; <del> } else throw "Musl libc only supports Linux systems."; </del> <ins> } else throw "Musl libc only supports 64-bit Linux systems."; </ins> # All packages built for i686 Linux. # Used by wine, firefox with debugging version of Flash, ...

I get this error when the packages i build contain any musl one. Blocking me from reviewing PRs. Full error: Issue for a more helpful error message: Steps to reproduce the behavior: No error. I think the solution would be to disable musl libc on i686-linux until it actually works. So Nix or nixpkgs-review don't even try to build it. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --- system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Collecting information: this looks fine maybe here needs to be a check for 64-bit


Question: <ins> { lib , ninja , meson , fetchFromGitLab , systemd , libgudev , pkg-config , glib , python3 , gobject-introspection }: python3.pkgs.buildPythonApplication rec { pname = "switcheroo-control"; version = "2.3"; format = "other"; src = fetchFromGitLab { domain = "gitlab.freedesktop.org"; owner = "hadess"; repo = pname; rev = version; hash = "sha256-1Pze2TJ9mggfcpiLFwJ7/9WhsdJx4G3GoA7+Z47shuc="; }; nativeBuildInputs = [ ninja meson pkg-config # needed for glib-compile-resources glib ]; buildInputs = [ systemd libgudev ]; propagatedBuildInputs = [ python3.pkgs.pygobject3 ]; mesonFlags = [ "-Dsystemdsystemunitdir=${placeholder "out"}/etc/systemd/system" "-Dhwdbdir=${placeholder "out"}/etc/udev/hwdb.d" ]; meta = with lib; { description = "D-Bus service to check the availability of dual-GPU"; homepage = "https://gitlab.freedesktop.org/hadess/switcheroo-control/"; changelog = "https://gitlab.freedesktop.org/hadess/switcheroo-control/-/blob/${version}/NEWS"; license = licenses.gpl3Plus; maintainers = [ ]; platforms = platforms.linux; }; } </ins>

Project description A dbus api to start programs on a different GPU Metadata homepage URL: source license: gpl3 platforms: linux
Duplicate


Question: (lib.enableFeature polkitSupport "polkit") ] ++ lib.optionals stdenv.isLinux [ "--enable-ipcdir=/run/pcscd" <del> "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system" </del> <ins> "--with-systemdsystemunitdir=${placeholder "out"}/lib/systemd/system" </ins> ]; makeFlags = [


Question: (lib.enableFeature polkitSupport "polkit") ] ++ lib.optionals stdenv.isLinux [ "--enable-ipcdir=/run/pcscd" <del> "--with-systemdsystemunitdir=${placeholder "bin"}/lib/systemd/system" </del> <ins> "--with-systemdsystemunitdir=${placeholder "out"}/lib/systemd/system" </ins> ]; makeFlags = [


Question: #   rev-version = /* human readable version; i.e. "unstable-2022-26-07" */; #   sha256 = /* checksum for this release, can omit if specifying your own `monorepoSrc` */; # } <del> , officialRelease ? { version = "18.1.4"; sha256 = "sha256-LyQEb4ZJXm2hkPOM9XITIploMT2VKIQWxUFio7SXrc0="; } </del> <ins> , officialRelease ? { version = "18.1.5"; sha256 = "0n44chqn96xsa00ryhwk8g0vv3zx908xjakkgjsa14sjr9mcsq8q"; } </ins> # i.e.: # { #   version = /* i.e. "15.0.0" */;

Package name: LLVM Latest released version: <!-- Search your package here: --- Current version on the unstable channel: 18.1.4 Current version on the stable/release channel: 18.1.4 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Want to submit a PR? The last upgrade was very straightforward:
I'll give it a shot


Question: miniupnpd = callPackage ../tools/networking/miniupnpd { }; <ins> miniupnpd-nftables = callPackage ../tools/networking/miniupnpd { firewall = "nftables"; }; </ins> miniball = callPackage ../development/libraries/miniball { }; minijail = callPackage ../tools/system/minijail { };

We already have in , but only with iptables support. It would be nice to have the nftables version available as well.
Being worked on in , I'm trying to test myself but couldn't make it to work yet.
I think the PR is ready now, testing welcome!
Maybe add an option for will be better?


Question: linux_5_15_hardened = hardenedKernelFor kernels.linux_5_15 { }; linux_6_1_hardened = hardenedKernelFor kernels.linux_6_1 { }; linux_6_5_hardened = hardenedKernelFor kernels.linux_6_5 { }; <ins> linux_6_6_hardened = hardenedKernelFor kernels.linux_6_6 { }; </ins> } // lib.optionalAttrs config.allowAliases { linux_4_9 = throw "linux 4.9 was removed because it will reach its end of life within 22.11";

Project description Hardened patchset got released for Linux 6.6. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hi, created the following merge request. Would appreciate a review.
will try to check that tomorrow's morning if my ibs allows me to, thanks


Question: <del> { stdenv, buildPythonPackage, fetchPypi, isPy3k , Mako, packaging, pysocks, pygments, ROPGadget , capstone, paramiko, pip, psutil , pyelftools, pyserial, dateutil , requests, tox, unicorn, intervaltree, fetchpatch }: </del> <ins> { stdenv , buildPythonPackage , fetchPypi , isPy3k , Mako , packaging , pysocks , pygments , ROPGadget , capstone , paramiko , pip , psutil , pyelftools , pyserial , dateutil , requests , tox , unicorn , intervaltree , fetchpatch }: </ins> buildPythonPackage rec { <del> version = "4.1.1"; </del> <ins> version = "4.2.1"; </ins> pname = "pwntools"; src = fetchPypi { inherit pname version; <del> sha256 = "694ce7a6cfca0ad40eae36c1d2663c44eb953f84785c63daa9752b4dfa7f39d8"; </del> <ins> sha256 = "1fh7sq9wrcfvn44qryln9cyg99pilvyq9bp80758lgdd6ss6hdqd"; </ins> }; <del> propagatedBuildInputs = [ Mako packaging pysocks pygments ROPGadget capstone paramiko pip psutil pyelftools pyserial dateutil requests tox unicorn intervaltree ]; </del> <ins> # Upstream has set an upper bound on unicorn because of https://github.com/Gallopsled/pwntools/issues/1538, # but since that is a niche use case and it requires extra work to get unicorn 1.0.2rc3 to work we relax # the bound here. Check if this is still necessary when updating! postPatch = '' sed -i 's/unicorn>=1.0.2rc1,<1.0.2rc4/unicorn>=1.0.2rc1/' setup.py ''; propagatedBuildInputs = [ Mako packaging pysocks pygments ROPGadget capstone paramiko pip psutil pyelftools pyserial dateutil requests tox unicorn intervaltree ]; </ins> doCheck = false; # no setuptools tests for the package

Describe the bug building the package fails. To Reproduce Steps to reproduce the behavior: and wait Expected behavior Successfully building python37Packages.pwntools to be used. Notify maintainers Maintainer: Metadata Error
Will be fixed via
lol, I didn't see this issue, I started fixing it today because I recently noticed it was broken as well :D


Question: <del> { cmake , cudaPackages , fetchFromGitHub , lib , ninja , pkgs , python3Packages ? { } , pythonSupport ? false , stdenv , symlinkJoin , which }: let </del> <ins> { cmake, cudaPackages, fetchFromGitHub, lib, ninja, python3Packages ? {}, pythonSupport ? false, stdenv, symlinkJoin, which, }: let </ins> inherit (lib) lists strings; inherit (cudaPackages) backendStdenv cudaFlags; cuda-common-redist = with cudaPackages; [ <ins> cuda_cudart # cuda_runtime.h </ins> libcublas # cublas_v2.h libcusolver # cusolverDn.h libcusparse # cusparse.h

Originally spotted by (thank you!). Steps to reproduce the behavior (assuming and are both ): The environment variable contains semicolons and must be quoted, otherwise bash will interpret the semicolons as command separators.
- Hey, I am not sure how to clean up the mess I just made on . Really embarrassed. I intended to rebase and hit merge instead, which pulled in 10k changes.
No worries, Happens to everyone at some point :) Personally, I'd just open a new PR.
Here it is: . Does the commit history look clean enough? I'll try to rebase it later, but I am concerned about retagging all of those folks.
I'd say don't worry about it -- as far as best practice goes, I'm actually not sure what's recommended for commits. do we recommend squashing before merge? I know I typically just do force pushes to avoid any commit history :l
I went ahead and squashed, and I'll post a nixpkgs-review when it's finished.
I don't think we have an official stance on this. Contributors use their best judgement for whatever keeps the commit history simplest and easiest to use


Question: ]; buildInputs = [ <del> alsa-lib </del> fluidsynth glib iir1

Steps to reproduce the behavior: dosbox-staging on darwin Complaining that alsa-lib not available on darwin I suggest referencing the derivation of in which use to opt-in dependencies P.S. wonder why the maintenance of this package is separated from and Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I don't have a Darwin machine. Nice. A full log would be nicer of course, but nice nonetheless. Wonder why they should be maintained by the same people.


Question: LIBRARY_PATH = if nativeComp then "${lib.getLib stdenv.cc.libc}/lib" else ""; <del> nativeBuildInputs = [ pkgconfig makeWrapper ] </del> <ins> nativeBuildInputs = [ pkgconfig makeWrapper nukeReferences ] </ins> ++ lib.optionals srcRepo [ autoreconfHook texinfo ] ++ lib.optional (withX && (withGTK3 || withXwidgets)) wrapGAppsHook;

Describe the bug In NixOS 20.09, Emacs now has the output of gtk+ in its closure, which in turn causes it to pull in stuff like mesa-drivers (424 MiB): This caused the closure size of Emacs to increase from 339 MiB in NixOS 20.03 to 1324 MiB in 20.09. Metadata NixOS 20.09..
cc
This was reverted in
This issue has been mentioned on NixOS Discourse. There might be relevant details there:


Question: [ "-rtlib=compiler-rt" "-Wno-unused-command-line-argument" "-B${targetLlvmLibraries.compiler-rt}/lib" <del> # Combat "__cxxabi_config.h not found". Maybe this could be fixed by # copying these headers into libcxx? Note that building libcxx # outside of monorepo isn't supported anymore, might be related to # https://github.com/llvm/llvm-project/issues/55632 # ("16.0.3 libcxx, libcxxabi: circular build dependencies") # Looks like the machinery changed in https://reviews.llvm.org/D120727. "-I${lib.getDev targetLlvmLibraries.libcxx.cxxabi}/include/c++/v1" </del> ] ++ lib.optional (!stdenv.targetPlatform.isWasm) "--unwindlib=libunwind" ++ lib.optional

Clang's wrapper does not set as an include path. Compiling files with since <cxxabi.hrequires is present in the aforementioned path I created the environment using this minimal mkShell expression Adding to
Proposed solution seems reasonable to me. See also started by
Please can you also include the nixpkgs commit hash in the repro (sorry if it's there and I missed it).
Oh thank you, that makes so much sense, I was also looking at how the monorepo handles things as well as their tests on finding the system include headers and what you said is probably the correct reason. Ah, it was the nixpkgs-unstable revision updated just then. Sorry I do not have that, but you can reproduce it with the current master as well.


Question: , profile ? "/etc/g810-led/profile" }: <del> stdenv.mkDerivation rec { </del> <ins> stdenv.mkDerivation (finalAttrs: { </ins> pname = "g810-led"; version = "0.4.3"; src = fetchFromGitHub { owner = "MatMoul"; <del> repo = pname; rev = "refs/tags/v${version}"; </del> <ins> repo = "g810-led"; rev = "refs/tags/v${finalAttrs.version}"; </ins> hash = "sha256-GKHtQ7DinqfhclDdPO94KtTLQhhonAoWS4VOvs6CMhY="; };

Steps to reproduce the behavior: g810-led Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:


Question: Rosalie's Mupen GUI is a free and open-source mupen64plus front-end written in C++. It offers a simple-to-use user interface. ''; <del> license = licenses.gpl3; </del> <ins> license = if withAngrylionRdpPlus then licenses.unfree else licenses.gpl3Only; </ins> platforms = platforms.linux; mainProgram = "RMG"; maintainers = with maintainers; [ slam-bert ];

There is a license violation in the package. The package contains the code for under the old MAME license which is non-commercial and incompatible with the GPL code in the rest of the program. I tried to notify upstream, but that didn't seem to go well...
Hello! It seems that upstream actually an option to disable in version of . , from my testing, gives me an error when I try to run it. You can find more info in this . So, i think merging the pull request linked to this issue is the best option right now.


Question: }; }; <ins> pid = buildPythonPackage rec { name = "pid-${version}"; version = "2.0.1"; src = pkgs.fetchurl { url = "https://pypi.python.org/packages/source/p/pid/${name}.tar.gz"; sha256 = "0cylj8p25nwkdfgy4pzai21wyzmrxdqlwwbzqag9gb5qcjfdwk05"; }; meta = { description = "Pidfile featuring stale detection and file-locking"; homepage = https://github.com/trbs/pid/; license = licenses.asl20; }; }; </ins> pydns = buildPythonPackage rec { name = "pydns-2.3.6"; disabled = isPy3k;

To make sure that we are on the same page: Kernel: System: Nix version: Nixpkgs version: broke legacy packages (only tested with the -set). Multiple options to solve this: revert the commit (an update will eventually have to be done) make sure no-one depends on sqlalchemy legacy versions (this would be the best choice, but can require a big amount of work) re-introduce an outdated version only used by legacy version (I’ll prepare a PR shortly that follows this path) cc
To be complete, the build problem is a test failure: I also checked, we cannot downgrade sqlite only for few pythonPackages, the entire python (and package set) have to be changed. Any preferred way to go?
(We should check if we still need this version, have it removed locally for virtmanager, virtinst as it isn't used, but haven't had the time to push that)
Yes, this is the preferred way to go. I began that but did not finish it yet, and it impacts some important parts (it causes xen to fail) I would prefer not to break because of unsufficient testing from me. This is in progress but could require some time to complete.
FYI xen already fails on
FYI: I switched away from sqlalchemy7 in yesterday.
Apart from virtinst, acd_cli, beaker, coilmq, and geeknote are the only revdeps of sqlalchemy7, as far as I can tell.
I openned to do some cleanup on sqlalchemy7. There still is that explicitly require . The same work will have to be done for and .
This should have remained open.
Using an older version of sqlite requires overriding the derivations of the interpreters.
See


Question: }; }; <del> config = let igpuDriver = if pCfg.intelBusId != "" then "modesetting" else "amdgpu"; igpuBusId = if pCfg.intelBusId != "" then pCfg.intelBusId else pCfg.amdgpuBusId; in lib.mkIf (nvidia_x11 != null) (lib.mkMerge [ # Common ({ assertions = [ { assertion = !(nvidiaEnabled && cfg.datacenter.enable); message = "You cannot configure both X11 and Data Center drivers at the same time."; } ]; boot = { blacklistedKernelModules = ["nouveau" "nvidiafb"]; # Don't add `nvidia-uvm` to `kernelModules`, because we want # `nvidia-uvm` be loaded only after `udev` rules for `nvidia` kernel # module are applied. # # Instead, we use `softdep` to lazily load `nvidia-uvm` kernel module # after `nvidia` kernel module is loaded and `udev` rules are applied. extraModprobeConfig = '' softdep nvidia post: nvidia-uvm ''; }; systemd.tmpfiles.rules = lib.optional config.virtualisation.docker.enableNvidia "L+ /run/nvidia-docker/bin - - - - ${nvidia_x11.bin}/origBin"; services.udev.extraRules = '' # Create /dev/nvidia-uvm when the nvidia-uvm module is loaded. KERNEL=="nvidia", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidiactl c 195 255'" KERNEL=="nvidia", RUN+="${pkgs.runtimeShell} -c 'for i in $$(cat /proc/driver/nvidia/gpus/*/information | grep Minor | cut -d   -f 4); do mknod -m 666 /dev/nvidia$${i} c 195 $${i}; done'" KERNEL=="nvidia_modeset", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-modeset c 195 254'" KERNEL=="nvidia_uvm", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-uvm c $$(grep nvidia-uvm /proc/devices | cut -d   -f 1) 0'" KERNEL=="nvidia_uvm", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-uvm-tools c $$(grep nvidia-uvm /proc/devices | cut -d   -f 1) 1'" ''; hardware.opengl = { extraPackages = [ nvidia_x11.out ]; extraPackages32 = [ nvidia_x11.lib32 </del> <ins> config = let igpuDriver = if pCfg.intelBusId != "" then "modesetting" else "amdgpu"; igpuBusId = if pCfg.intelBusId != "" then pCfg.intelBusId else pCfg.amdgpuBusId; in lib.mkIf (nvidia_x11 != null) ( lib.mkMerge [ # Common ({ assertions = [ { assertion = !(nvidiaEnabled && cfg.datacenter.enable); message = "You cannot configure both X11 and Data Center drivers at the same time."; } </ins> ]; <del> }; environment.systemPackages = [ nvidia_x11.bin ]; }) # X11 (lib.mkIf nvidiaEnabled { assertions = [ { assertion = primeEnabled -> pCfg.intelBusId == "" || pCfg.amdgpuBusId == ""; message = "You cannot configure both an Intel iGPU and an AMD APU. Pick the one corresponding to your processor."; } { assertion = offloadCfg.enableOffloadCmd -> offloadCfg.enable || reverseSyncCfg.enable; message = "Offload command requires offloading or reverse prime sync to be enabled."; } { assertion = primeEnabled -> pCfg.nvidiaBusId != "" && (pCfg.intelBusId != "" || pCfg.amdgpuBusId != ""); message = "When NVIDIA PRIME is enabled, the GPU bus IDs must be configured."; } { assertion = offloadCfg.enable -> lib.versionAtLeast nvidia_x11.version "435.21"; message = "NVIDIA PRIME render offload is currently only supported on versions >= 435.21."; } { assertion = (reverseSyncCfg.enable && pCfg.amdgpuBusId != "") -> lib.versionAtLeast nvidia_x11.version "470.0"; message = "NVIDIA PRIME render offload for AMD APUs is currently only supported on versions >= 470 beta."; } { assertion = !(syncCfg.enable && offloadCfg.enable); message = "PRIME Sync and Offload cannot be both enabled"; } { assertion = !(syncCfg.enable && reverseSyncCfg.enable); message = "PRIME Sync and PRIME Reverse Sync cannot be both enabled"; } { assertion = !(syncCfg.enable && cfg.powerManagement.finegrained); message = "Sync precludes powering down the NVIDIA GPU."; } { assertion = cfg.powerManagement.finegrained -> offloadCfg.enable; message = "Fine-grained power management requires offload to be enabled."; } { assertion = cfg.powerManagement.enable -> lib.versionAtLeast nvidia_x11.version "430.09"; message = "Required files for driver based power management only exist on versions >= 430.09."; } { assertion = cfg.open -> (cfg.package ? open && cfg.package ? firmware); message = "This version of NVIDIA driver does not provide a corresponding opensource kernel driver"; } { assertion = cfg.dynamicBoost.enable -> lib.versionAtLeast nvidia_x11.version "510.39.01"; message = "NVIDIA's Dynamic Boost feature only exists on versions >= 510.39.01"; }]; # If Optimus/PRIME is enabled, we: # - Specify the configured NVIDIA GPU bus ID in the Device section for the #   "nvidia" driver. # - Add the AllowEmptyInitialConfiguration option to the Screen section for the #   "nvidia" driver, in order to allow the X server to start without any outputs. # - Add a separate Device section for the Intel GPU, using the "modesetting" #   driver and with the configured BusID. # - OR add a separate Device section for the AMD APU, using the "amdgpu" #   driver and with the configures BusID. # - Reference that Device section from the ServerLayout section as an inactive #   device. # - Configure the display manager to run specific `xrandr` commands which will #   configure/enable displays connected to the Intel iGPU / AMD APU. # reverse sync implies offloading hardware.nvidia.prime.offload.enable = lib.mkDefault reverseSyncCfg.enable; services.xserver.drivers = lib.optional primeEnabled { name = igpuDriver; display = offloadCfg.enable; modules = lib.optional (igpuDriver == "amdgpu") pkgs.xorg.xf86videoamdgpu; deviceSection = '' BusID "${igpuBusId}" '' + lib.optionalString (syncCfg.enable && igpuDriver != "amdgpu") '' Option "AccelMethod" "none" ''; } ++ lib.singleton { name = "nvidia"; modules = [nvidia_x11.bin]; display = !offloadCfg.enable; deviceSection = '' Option "SidebandSocketPath" "/run/nvidia-xdriver/" '' + lib.optionalString primeEnabled '' BusID "${pCfg.nvidiaBusId}" '' + lib.optionalString pCfg.allowExternalGpu '' Option "AllowExternalGpus" ''; screenSection = '' Option "RandRRotation" "on" '' + lib.optionalString syncCfg.enable '' Option "AllowEmptyInitialConfiguration" '' + lib.optionalString cfg.forceFullCompositionPipeline '' Option         "metamodes" "nvidia-auto-select +0+0 {ForceFullCompositionPipeline=On}" Option         "AllowIndirectGLXProtocol" "off" Option         "TripleBuffer" "on" ''; </del> <ins> boot = { blacklistedKernelModules = [ "nouveau" "nvidiafb" ]; # Don't add `nvidia-uvm` to `kernelModules`, because we want # `nvidia-uvm` be loaded only after `udev` rules for `nvidia` kernel # module are applied. # # Instead, we use `softdep` to lazily load `nvidia-uvm` kernel module # after `nvidia` kernel module is loaded and `udev` rules are applied. extraModprobeConfig = '' softdep nvidia post: nvidia-uvm ''; </ins> }; <del> services.xserver.serverLayoutSection = lib.optionalString syncCfg.enable '' Inactive "Device-${igpuDriver}[0]" '' + lib.optionalString reverseSyncCfg.enable '' Inactive "Device-nvidia[0]" '' + lib.optionalString offloadCfg.enable '' Option "AllowNVIDIAGPUScreens" </del> <ins> systemd.tmpfiles.rules = lib.optional config.virtualisation.docker.enableNvidia "L+ /run/nvidia-docker/bin - - - - ${nvidia_x11.bin}/origBin"; services.udev.extraRules = '' # Create /dev/nvidia-uvm when the nvidia-uvm module is loaded. KERNEL=="nvidia", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidiactl c 195 255'" KERNEL=="nvidia", RUN+="${pkgs.runtimeShell} -c 'for i in $$(cat /proc/driver/nvidia/gpus/*/information | grep Minor | cut -d   -f 4); do mknod -m 666 /dev/nvidia$${i} c 195 $${i}; done'" KERNEL=="nvidia_modeset", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-modeset c 195 254'" KERNEL=="nvidia_uvm", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-uvm c $$(grep nvidia-uvm /proc/devices | cut -d   -f 1) 0'" KERNEL=="nvidia_uvm", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-uvm-tools c $$(grep nvidia-uvm /proc/devices | cut -d   -f 1) 1'" </ins> ''; <ins> hardware.opengl = { extraPackages = [ nvidia_x11.out ]; extraPackages32 = [ nvidia_x11.lib32 ]; }; environment.systemPackages = [ nvidia_x11.bin ]; }) # X11 (lib.mkIf nvidiaEnabled { assertions = [ { assertion = primeEnabled -> pCfg.intelBusId == "" || pCfg.amdgpuBusId == ""; message = "You cannot configure both an Intel iGPU and an AMD APU. Pick the one corresponding to your processor."; } { assertion = offloadCfg.enableOffloadCmd -> offloadCfg.enable || reverseSyncCfg.enable; message = "Offload command requires offloading or reverse prime sync to be enabled."; } { assertion = primeEnabled -> pCfg.nvidiaBusId != "" && (pCfg.intelBusId != "" || pCfg.amdgpuBusId != ""); message = "When NVIDIA PRIME is enabled, the GPU bus IDs must be configured."; } { assertion = offloadCfg.enable -> lib.versionAtLeast nvidia_x11.version "435.21"; message = "NVIDIA PRIME render offload is currently only supported on versions >= 435.21."; } { assertion = (reverseSyncCfg.enable && pCfg.amdgpuBusId != "") -> lib.versionAtLeast nvidia_x11.version "470.0"; message = "NVIDIA PRIME render offload for AMD APUs is currently only supported on versions >= 470 beta."; } { assertion = !(syncCfg.enable && offloadCfg.enable); message = "PRIME Sync and Offload cannot be both enabled"; } { assertion = !(syncCfg.enable && reverseSyncCfg.enable); message = "PRIME Sync and PRIME Reverse Sync cannot be both enabled"; } { assertion = !(syncCfg.enable && cfg.powerManagement.finegrained); message = "Sync precludes powering down the NVIDIA GPU."; } { assertion = cfg.powerManagement.finegrained -> offloadCfg.enable; message = "Fine-grained power management requires offload to be enabled."; } { assertion = cfg.powerManagement.enable -> lib.versionAtLeast nvidia_x11.version "430.09"; message = "Required files for driver based power management only exist on versions >= 430.09."; } { assertion = cfg.open -> (cfg.package ? open && cfg.package ? firmware); message = "This version of NVIDIA driver does not provide a corresponding opensource kernel driver"; } { assertion = cfg.dynamicBoost.enable -> lib.versionAtLeast nvidia_x11.version "510.39.01"; message = "NVIDIA's Dynamic Boost feature only exists on versions >= 510.39.01"; } ]; </ins> <del> services.xserver.displayManager.setupCommands = let gpuProviderName = if igpuDriver == "amdgpu" then # find the name of the provider if amdgpu "`${lib.getExe pkgs.xorg.xrandr} --listproviders | ${lib.getExe pkgs.gnugrep} -i AMD | ${lib.getExe pkgs.gnused} -n 's/^.*name://p'`" else igpuDriver; providerCmdParams = if syncCfg.enable then ""${gpuProviderName}" NVIDIA-0" else "NVIDIA-G0 "${gpuProviderName}""; in lib.optionalString (syncCfg.enable || reverseSyncCfg.enable) '' # Added by nvidia configuration module for Optimus/PRIME. ${lib.getExe pkgs.xorg.xrandr} --setprovideroutputsource ${providerCmdParams} ${lib.getExe pkgs.xorg.xrandr} --auto ''; </del> <ins> # If Optimus/PRIME is enabled, we: # - Specify the configured NVIDIA GPU bus ID in the Device section for the #   "nvidia" driver. # - Add the AllowEmptyInitialConfiguration option to the Screen section for the #   "nvidia" driver, in order to allow the X server to start without any outputs. # - Add a separate Device section for the Intel GPU, using the "modesetting" #   driver and with the configured BusID. # - OR add a separate Device section for the AMD APU, using the "amdgpu" #   driver and with the configures BusID. # - Reference that Device section from the ServerLayout section as an inactive #   device. # - Configure the display manager to run specific `xrandr` commands which will #   configure/enable displays connected to the Intel iGPU / AMD APU. # reverse sync implies offloading hardware.nvidia.prime.offload.enable = lib.mkDefault reverseSyncCfg.enable; services.xserver.drivers = lib.optional primeEnabled { name = igpuDriver; display = offloadCfg.enable; modules = lib.optional (igpuDriver == "amdgpu") pkgs.xorg.xf86videoamdgpu; deviceSection = '' BusID "${igpuBusId}" '' + lib.optionalString (syncCfg.enable && igpuDriver != "amdgpu") '' Option "AccelMethod" "none" ''; } ++ lib.singleton { name = "nvidia"; modules = [ nvidia_x11.bin ]; display = !offloadCfg.enable; deviceSection = '' Option "SidebandSocketPath" "/run/nvidia-xdriver/" '' + lib.optionalString primeEnabled '' BusID "${pCfg.nvidiaBusId}" '' + lib.optionalString pCfg.allowExternalGpu '' Option "AllowExternalGpus" ''; screenSection = '' Option "RandRRotation" "on" '' + lib.optionalString syncCfg.enable '' Option "AllowEmptyInitialConfiguration" '' + lib.optionalString cfg.forceFullCompositionPipeline '' Option         "metamodes" "nvidia-auto-select +0+0 {ForceFullCompositionPipeline=On}" Option         "AllowIndirectGLXProtocol" "off" Option         "TripleBuffer" "on" ''; }; </ins> <del> environment.etc = { "nvidia/nvidia-application-profiles-rc" = lib.mkIf nvidia_x11.useProfiles {source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc";}; </del> <ins> services.xserver.serverLayoutSection = lib.optionalString syncCfg.enable '' Inactive "Device-${igpuDriver}[0]" '' + lib.optionalString reverseSyncCfg.enable '' Inactive "Device-nvidia[0]" '' + lib.optionalString offloadCfg.enable '' Option "AllowNVIDIAGPUScreens" ''; services.xserver.displayManager.setupCommands = let gpuProviderName = if igpuDriver == "amdgpu" then # find the name of the provider if amdgpu "`${lib.getExe pkgs.xorg.xrandr} --listproviders | ${lib.getExe pkgs.gnugrep} -i AMD | ${lib.getExe pkgs.gnused} -n 's/^.*name://p'`" else igpuDriver; providerCmdParams = if syncCfg.enable then ""${gpuProviderName}" NVIDIA-0" else "NVIDIA-G0 "${gpuProviderName}""; in lib.optionalString (syncCfg.enable || reverseSyncCfg.enable) '' # Added by nvidia configuration module for Optimus/PRIME. ${lib.getExe pkgs.xorg.xrandr} --setprovideroutputsource ${providerCmdParams} ${lib.getExe pkgs.xorg.xrandr} --auto ''; environment.etc = { "nvidia/nvidia-application-profiles-rc" = lib.mkIf nvidia_x11.useProfiles { source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc"; }; </ins> <del> # 'nvidia_x11' installs it's files to /run/opengl-driver/... "egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; }; </del> <ins> # 'nvidia_x11' installs it's files to /run/opengl-driver/... "egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; }; </ins> <del> hardware.opengl = { extraPackages = [ pkgs.nvidia-vaapi-driver ]; extraPackages32 = [ pkgs.pkgsi686Linux.nvidia-vaapi-driver ]; }; environment.systemPackages = lib.optional cfg.nvidiaSettings nvidia_x11.settings ++ lib.optional cfg.nvidiaPersistenced nvidia_x11.persistenced ++ lib.optional offloadCfg.enableOffloadCmd (pkgs.writeShellScriptBin "nvidia-offload" '' export __NV_PRIME_RENDER_OFFLOAD=1 export __NV_PRIME_RENDER_OFFLOAD_PROVIDER=NVIDIA-G0 export __GLX_VENDOR_LIBRARY_NAME=nvidia export __VK_LAYER_NV_optimus=NVIDIA_only exec "$@" ''); systemd.packages = lib.optional cfg.powerManagement.enable nvidia_x11.out; systemd.services = let nvidiaService = state: { description = "NVIDIA system ${state} actions"; path = [pkgs.kbd]; serviceConfig = { Type = "oneshot"; ExecStart = "${nvidia_x11.out}/bin/nvidia-sleep.sh '${state}'"; }; before = ["systemd-${state}.service"]; requiredBy = ["systemd-${state}.service"]; </del> <ins> hardware.opengl = { extraPackages = [ pkgs.nvidia-vaapi-driver ]; extraPackages32 = [ pkgs.pkgsi686Linux.nvidia-vaapi-driver ]; </ins> }; <del> in lib.mkMerge [ (lib.mkIf cfg.powerManagement.enable { nvidia-suspend = nvidiaService "suspend"; nvidia-hibernate = nvidiaService "hibernate"; nvidia-resume = (nvidiaService "resume") // { before = []; after = ["systemd-suspend.service" "systemd-hibernate.service"]; requiredBy = ["systemd-suspend.service" "systemd-hibernate.service"]; }; }) (lib.mkIf cfg.nvidiaPersistenced { "nvidia-persistenced" = { description = "NVIDIA Persistence Daemon"; wantedBy = ["multi-user.target"]; </del> <ins> environment.systemPackages = lib.optional cfg.nvidiaSettings nvidia_x11.settings ++ lib.optional cfg.nvidiaPersistenced nvidia_x11.persistenced ++ lib.optional offloadCfg.enableOffloadCmd ( pkgs.writeShellScriptBin "nvidia-offload" '' export __NV_PRIME_RENDER_OFFLOAD=1 export __NV_PRIME_RENDER_OFFLOAD_PROVIDER=NVIDIA-G0 export __GLX_VENDOR_LIBRARY_NAME=nvidia export __VK_LAYER_NV_optimus=NVIDIA_only exec "$@" '' ); systemd.packages = lib.optional cfg.powerManagement.enable nvidia_x11.out; systemd.services = let nvidiaService = state: { description = "NVIDIA system ${state} actions"; path = [ pkgs.kbd ]; </ins> serviceConfig = { <del> Type = "forking"; Restart = "always"; PIDFile = "/var/run/nvidia-persistenced/nvidia-persistenced.pid"; ExecStart = "${lib.getExe nvidia_x11.persistenced} --verbose"; ExecStopPost = "${pkgs.coreutils}/bin/rm -rf /var/run/nvidia-persistenced"; </del> <ins> Type = "oneshot"; ExecStart = "${nvidia_x11.out}/bin/nvidia-sleep.sh '${state}'"; </ins> }; <ins> before = [ "systemd-${state}.service" ]; requiredBy = [ "systemd-${state}.service" ]; </ins> }; <del> }) (lib.mkIf cfg.dynamicBoost.enable { "nvidia-powerd" = { description = "nvidia-powerd service"; path = [ pkgs.util-linux # nvidia-powerd wants lscpu ]; wantedBy = ["multi-user.target"]; serviceConfig = { Type = "dbus"; BusName = "nvidia.powerd.server"; ExecStart = "${nvidia_x11.bin}/bin/nvidia-powerd"; </del> <ins> in lib.mkMerge [ (lib.mkIf cfg.powerManagement.enable { nvidia-suspend = nvidiaService "suspend"; nvidia-hibernate = nvidiaService "hibernate"; nvidia-resume = (nvidiaService "resume") // { before = [ ]; after = [ "systemd-suspend.service" "systemd-hibernate.service" ]; requiredBy = [ "systemd-suspend.service" "systemd-hibernate.service" ]; </ins> }; <del> }; }) ]; services.acpid.enable = true; services.dbus.packages = lib.optional cfg.dynamicBoost.enable nvidia_x11.bin; hardware.firmware = lib.optional cfg.open nvidia_x11.firmware; systemd.tmpfiles.rules = [ # Remove the following log message: #    (WW) NVIDIA: Failed to bind sideband socket to #    (WW) NVIDIA:     '/var/run/nvidia-xdriver-b4f69129' Permission denied # # https://bbs.archlinux.org/viewtopic.php?pid=1909115#p1909115 "d /run/nvidia-xdriver 0770 root users" ] ++ lib.optional (nvidia_x11.persistenced != null && config.virtualisation.docker.enableNvidia) "L+ /run/nvidia-docker/extras/bin/nvidia-persistenced - - - - ${nvidia_x11.persistenced}/origBin/nvidia-persistenced"; boot = { extraModulePackages = if cfg.open then [nvidia_x11.open] else [nvidia_x11.bin]; # nvidia-uvm is required by CUDA applications. kernelModules = lib.optionals config.services.xserver.enable ["nvidia" "nvidia_modeset" "nvidia_drm"]; # If requested enable modesetting via kernel parameter. kernelParams = lib.optional (offloadCfg.enable || cfg.modesetting.enable) "nvidia-drm.modeset=1" ++ lib.optional cfg.powerManagement.enable "nvidia.NVreg_PreserveVideoMemoryAllocations=1" ++ lib.optional cfg.open "nvidia.NVreg_OpenRmEnableUnsupportedGpus=1" ++ lib.optional (config.boot.kernelPackages.kernel.kernelAtLeast "6.2" && !ibtSupport) "ibt=off"; # enable finegrained power management extraModprobeConfig = lib.optionalString cfg.powerManagement.finegrained '' options nvidia "NVreg_DynamicPowerManagement=0x02" ''; }; services.udev.extraRules = lib.optionalString cfg.powerManagement.finegrained ( lib.optionalString (lib.versionOlder config.boot.kernelPackages.kernel.version "5.5") '' # Remove NVIDIA USB xHCI Host Controller devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x0c0330", ATTR{remove}="1" # Remove NVIDIA USB Type-C UCSI devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x0c8000", ATTR{remove}="1" # Remove NVIDIA Audio devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x040300", ATTR{remove}="1" '' + '' # Enable runtime PM for NVIDIA VGA/3D controller devices on driver bind ACTION=="bind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030000", TEST=="power/control", ATTR{power/control}="auto" ACTION=="bind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030200", TEST=="power/control", ATTR{power/control}="auto" # Disable runtime PM for NVIDIA VGA/3D controller devices on driver unbind ACTION=="unbind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030000", TEST=="power/control", ATTR{power/control}="on" ACTION=="unbind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030200", TEST=="power/control", ATTR{power/control}="on" '' ); }) # Data Center (lib.mkIf (cfg.datacenter.enable) { boot.extraModulePackages = [ nvidia_x11.bin ]; systemd = { tmpfiles.rules = lib.optional (nvidia_x11.persistenced != null && config.virtualisation.docker.enableNvidia) "L+ /run/nvidia-docker/extras/bin/nvidia-persistenced - - - - ${nvidia_x11.persistenced}/origBin/nvidia-persistenced"; services = lib.mkMerge [ ({ nvidia-fabricmanager = { enable = true; description = "Start NVIDIA NVLink Management"; wantedBy = [ "multi-user.target" ]; unitConfig.After = [ "network-online.target" ]; unitConfig.Requires = [ "network-online.target" ]; serviceConfig = { Type = "forking"; TimeoutStartSec = 240; ExecStart = let nv-fab-conf = settingsFormat.generate "fabricmanager.conf" cfg.datacenter.settings; in </del> <ins> }) (lib.mkIf cfg.nvidiaPersistenced { "nvidia-persistenced" = { description = "NVIDIA Persistence Daemon"; wantedBy = [ "multi-user.target" ]; serviceConfig = { Type = "forking"; Restart = "always"; PIDFile = "/var/run/nvidia-persistenced/nvidia-persistenced.pid"; ExecStart = "${lib.getExe nvidia_x11.persistenced} --verbose"; ExecStopPost = "${pkgs.coreutils}/bin/rm -rf /var/run/nvidia-persistenced"; }; }; }) (lib.mkIf cfg.dynamicBoost.enable { "nvidia-powerd" = { description = "nvidia-powerd service"; path = [ pkgs.util-linux # nvidia-powerd wants lscpu ]; wantedBy = [ "multi-user.target" ]; serviceConfig = { Type = "dbus"; BusName = "nvidia.powerd.server"; ExecStart = "${nvidia_x11.bin}/bin/nvidia-powerd"; }; }; }) ]; services.acpid.enable = true; services.dbus.packages = lib.optional cfg.dynamicBoost.enable nvidia_x11.bin; hardware.firmware = let isOpen = cfg.open; isNewUnfree = lib.versionAtLeast nvidia_x11.version "555"; in lib.optional (isOpen || isNewUnfree) nvidia_x11.firmware; systemd.tmpfiles.rules = [ # Remove the following log message: #    (WW) NVIDIA: Failed to bind sideband socket to #    (WW) NVIDIA:     '/var/run/nvidia-xdriver-b4f69129' Permission denied # # https://bbs.archlinux.org/viewtopic.php?pid=1909115#p1909115 "d /run/nvidia-xdriver 0770 root users" ] ++ lib.optional (nvidia_x11.persistenced != null && config.virtualisation.docker.enableNvidia) "L+ /run/nvidia-docker/extras/bin/nvidia-persistenced - - - - ${nvidia_x11.persistenced}/origBin/nvidia-persistenced"; boot = { extraModulePackages = if cfg.open then [ nvidia_x11.open ] else [ nvidia_x11.bin ]; # nvidia-uvm is required by CUDA applications. kernelModules = lib.optionals config.services.xserver.enable [ "nvidia" "nvidia_modeset" "nvidia_drm" ]; # If requested enable modesetting via kernel parameter. kernelParams = lib.optional (offloadCfg.enable || cfg.modesetting.enable) "nvidia-drm.modeset=1" ++ lib.optional cfg.powerManagement.enable "nvidia.NVreg_PreserveVideoMemoryAllocations=1" ++ lib.optional cfg.open "nvidia.NVreg_OpenRmEnableUnsupportedGpus=1" ++ lib.optional (config.boot.kernelPackages.kernel.kernelAtLeast "6.2" && !ibtSupport) "ibt=off"; # enable finegrained power management extraModprobeConfig = lib.optionalString cfg.powerManagement.finegrained '' options nvidia "NVreg_DynamicPowerManagement=0x02" ''; }; services.udev.extraRules = lib.optionalString cfg.powerManagement.finegrained ( lib.optionalString (lib.versionOlder config.boot.kernelPackages.kernel.version "5.5") '' # Remove NVIDIA USB xHCI Host Controller devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x0c0330", ATTR{remove}="1" # Remove NVIDIA USB Type-C UCSI devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x0c8000", ATTR{remove}="1" # Remove NVIDIA Audio devices, if present ACTION=="add", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x040300", ATTR{remove}="1" '' + '' # Enable runtime PM for NVIDIA VGA/3D controller devices on driver bind ACTION=="bind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030000", TEST=="power/control", ATTR{power/control}="auto" ACTION=="bind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030200", TEST=="power/control", ATTR{power/control}="auto" # Disable runtime PM for NVIDIA VGA/3D controller devices on driver unbind ACTION=="unbind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030000", TEST=="power/control", ATTR{power/control}="on" ACTION=="unbind", SUBSYSTEM=="pci", ATTR{vendor}=="0x10de", ATTR{class}=="0x030200", TEST=="power/control", ATTR{power/control}="on" '' ); }) # Data Center (lib.mkIf (cfg.datacenter.enable) { boot.extraModulePackages = [ nvidia_x11.bin ]; systemd = { tmpfiles.rules = lib.optional (nvidia_x11.persistenced != null && config.virtualisation.docker.enableNvidia) "L+ /run/nvidia-docker/extras/bin/nvidia-persistenced - - - - ${nvidia_x11.persistenced}/origBin/nvidia-persistenced"; services = lib.mkMerge [ ({ nvidia-fabricmanager = { enable = true; description = "Start NVIDIA NVLink Management"; wantedBy = [ "multi-user.target" ]; unitConfig.After = [ "network-online.target" ]; unitConfig.Requires = [ "network-online.target" ]; serviceConfig = { Type = "forking"; TimeoutStartSec = 240; ExecStart = let nv-fab-conf = settingsFormat.generate "fabricmanager.conf" cfg.datacenter.settings; in </ins> "${lib.getExe nvidia_x11.fabricmanager} -c ${nv-fab-conf}"; <del> LimitCORE="infinity"; </del> <ins> LimitCORE = "infinity"; }; </ins> }; <del> }; }) (lib.mkIf cfg.nvidiaPersistenced { "nvidia-persistenced" = { description = "NVIDIA Persistence Daemon"; wantedBy = ["multi-user.target"]; serviceConfig = { Type = "forking"; Restart = "always"; PIDFile = "/var/run/nvidia-persistenced/nvidia-persistenced.pid"; ExecStart = "${lib.getExe nvidia_x11.persistenced} --verbose"; ExecStopPost = "${pkgs.coreutils}/bin/rm -rf /var/run/nvidia-persistenced"; </del> <ins> }) (lib.mkIf cfg.nvidiaPersistenced { "nvidia-persistenced" = { description = "NVIDIA Persistence Daemon"; wantedBy = [ "multi-user.target" ]; serviceConfig = { Type = "forking"; Restart = "always"; PIDFile = "/var/run/nvidia-persistenced/nvidia-persistenced.pid"; ExecStart = "${lib.getExe nvidia_x11.persistenced} --verbose"; ExecStopPost = "${pkgs.coreutils}/bin/rm -rf /var/run/nvidia-persistenced"; }; </ins> }; <del> }; }) ]; }; </del> <ins> }) ]; }; </ins> <del> environment.systemPackages = lib.optional cfg.datacenter.enable nvidia_x11.fabricmanager ++ lib.optional cfg.nvidiaPersistenced nvidia_x11.persistenced; }) ]); </del> <ins> environment.systemPackages = lib.optional cfg.datacenter.enable nvidia_x11.fabricmanager ++ lib.optional cfg.nvidiaPersistenced nvidia_x11.persistenced; }) ] ); </ins> }

Package name: Latest released version: 555.42.02 <!-- Search your package here: --- Current version on the unstable channel: 550.78 Current version on the stable/release channel: 545.29.02 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:


Question: csvkit = callPackage ../tools/text/csvkit { }; <ins> csvquote = callPackage ../tools/text/csvquote { }; </ins> csvtool = callPackage ../development/ocaml-modules/csv/csvtool.nix { }; csv2latex = callPackage ../tools/misc/csv2latex { };

Project description Enables common unix utlities like cut, awk, wc, head to work correctly with csv data containing delimiters and newlines Metadata homepage URL: source URL: license: mit platforms: unix, linux, darwin


Question: webstorm = buildWebStorm rec { name = "webstorm-${version}"; <del> version = "2019.3.4"; /* updated by script */ </del> <ins> version = "2020.1"; /* updated by script */ </ins> description = "Professional IDE for Web and JavaScript development"; license = stdenv.lib.licenses.unfree; src = fetchurl { url = "https://download.jetbrains.com/webstorm/WebStorm-${version}.tar.gz"; <del> sha256 = "0q3595r4m22wf5r5zyncr1zv7yap5przbzjnyf75y51mqwl1g61i"; /* updated by script */ </del> <ins> sha256 = "1c68li5jxsjml0macdb0s04llwwq1hni5z8vq2zdfcn5zm3xwpif"; /* updated by script */ </ins> }; wmClass = "jetbrains-webstorm"; update-channel = "WebStorm RELEASE";

Please update Goland to a current version. The Current Version is now 2020.1 Thx and Greetz


Question: inherit version; sha256 = "1vn1db2akw98ybnpns92qi11v94hydwp130s8753k6ikby95883j"; }; <ins> patches = oldAttrs.patches or [] ++ [ # Don't raise import error on non-linux os. Remove after upgrading to distro≥1.2.0 (fetchpatch { url = "https://github.com/nir0s/distro/commit/25aa3f8c5934346dc838387fc081ce81baddeb95.patch"; sha256 = "0m09ldf75gacazh2kr04cifgsqfxg670vk4ypl62zv7fp3nyd5dc"; }) ]; </ins> }); node-semver = super.node-semver.overridePythonAttrs (oldAttrs: rec { version = "0.6.1";

Description Attempting to install conan with nix-env on Mac OS X errors out with the following message: To Reproduce Steps to reproduce the behavior: Expected behavior As Mac OS X is a supported platform for conan, it's expected that it would install. Additional context This appears to be due to conan's dependency on the python3-distro package, which only compiles on Linux architectures. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(tclemons): channels(root): nixpkgs:


Question: package = mkPackageOption pkgs "navidrome" { }; settings = mkOption { <del> type = settingsFormat.type; default = { Address = "127.0.0.1"; Port = 4533; </del> <ins> type = submodule { freeformType = settingsFormat.type; options = { Address = mkOption { default = "127.0.0.1"; description = "Address to run Navidrome on."; type = str; }; Port = mkOption { default = 4533; description = "Port to run Navidrome on."; type = port; }; }; </ins> }; example = { MusicFolder = "/mnt/music";

Evaluation failure when setting and . Moreover setting any will "remove" the default values for and your system with these options: the failure: System builds, firewall is opened for the default 4533 port. This bug happens because the rather than for each individual setting. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
the Issue here is the option being null, you can use these options together if is supplied. if you encountered a different eval failure to this please attach it. Yes this is because those options values are supplied as apart of one default of as a whole, I am not aware of a nice way to give them a default independent of the rest of the settings being set or not. would giving this port value a catch for being null be an alright solution? e.g.. if is not set, then use the upstream default ( of 4533 I believe ) I don't really want to separate out these values from the . option so this wont address the removal of default values when setting them yourself to something different, I think this is expected enough* behavior. I think fixing this eval failure condition with simply supplying the default port where isn't supplied is reasonable enough, as anyone who wasnt going to set that in the first place is unlikely to care if its the same value in function either way. In fact i may just remove the default entirely and simply handle the case of no supplied value by assuming the default port (of 4533 ) in the openFirewall rule. I'll PR these changes once I get the time


Question: buildInputs = with self; [ nose sphinx numpydoc ]; <del> # Failing test on Python 3.x postPatch = '''' + optionalString isPy3k '' </del> <ins> # Failing test on Python 3.x and Darwin postPatch = '''' + optionalString (isPy3k || stdenv.isDarwin) '' </ins> sed -i -e '70,84d' joblib/test/test_format_stack.py # test_nested_parallel_warnings: ValueError: Non-zero return code: -9. # Not sure why but it's nix-specific. Try removing for new joblib releases.

I'm trying to install joblib for python 2.7 on a Mac, but the threading and multiprocessing tests fail. System: Darwin Kernel Version 13.4.0 Nix version: nix-env (Nix) 1.11.2 Nixpkgs version: "16.09pre83147."
As I mentioned in you're not supposed to install Python libraries like that. Even so, the error is still a bug. Unfortunately I'm not using OSX myself so I can't be much of help I'm afraid. I do know there are issues with multiprocessing on OSX with Apple vecLib / Accelerate.
Ok, now I know you have to use nix-shell to load python libraries. Just adding here that gives the same error.


Question: source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc"; }; <ins> # 'nvidia_x11' installs it's files to /run/opengl-driver/... environment.etc."egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; </ins> hardware.opengl.package = mkIf (!offloadCfg.enable) nvidia_x11.out; hardware.opengl.package32 = mkIf (!offloadCfg.enable) nvidia_x11.lib32; hardware.opengl.extraPackages = optional offloadCfg.enable nvidia_x11.out;

Yes. We have a package which is what I tried, but since it’s a thin wrapper around it’s possible that it’s still not built with the right options. Also I’ve noticed these messages from : does not show the extension, and GLX applications fail to start. Originally posted by in I probably merged , too early. I'm not totally sure this is working properly.
This is pretty much a help wanted because I lack the depth of knowledge and hardware to help anymore with Nvidia things. My goal with finishing was that it could be possible and improved upon. i.e packages are built with the capability etc.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
The last few evenings, I have tinkered around a bit. I was not successful so far. Here are my findings: I have set the following options: This page says that there is no acceleration support for xwayland and nvidia yet but glxgears fails to start, so I think this is another issue There are multiple versions of : One from the egl-wayland package, the other from nvidia-x11 package. As the one in is loaded, I tried to replace it with the one from egl-wayland. Though, the result is the same with both. When starting an application, which would use acceleration, I can observe this line in the kernel log: Using , I can see that is accessed, though one of the calls fails: one more thing: looking at , gnome-shell is listed. Maybe it has working acceleration? Edit: Got a bit further: Found a reference to an additional directory, which is used to look up libraries: Creating a file in there: with the file in /run/opengl-driver/lib/libnvidia-egl- being replaced by the one from egl-wayland package. Now the error in xwayland is just a warning: I can run a wayland native terminal, but still fails If you have any suggestions, what to try next, I would be glad to give it a try.
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant.


Question: source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc"; }; <ins> # 'nvidia_x11' installs it's files to /run/opengl-driver/... environment.etc."egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; </ins> hardware.opengl.package = mkIf (!offloadCfg.enable) nvidia_x11.out; hardware.opengl.package32 = mkIf (!offloadCfg.enable) nvidia_x11.lib32; hardware.opengl.extraPackages = optional offloadCfg.enable nvidia_x11.out;

This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
I'm trying to get this working as well. However I can't even get the session chooser in GDM in 20.09. Is it only working in unstable? Any tips? Here's my config
With this overlay and the 470.42.01 driver, nvidia is usable with xwayland. :tada: , unigene-valley and so far every game I started on Steam. Only issues I have so far are that chrome does not start properly Workaround is to start it with some options: and in CSGO there is noticeable input delay.
I've updated to the latest nixos-unstable () which includes updated & , but I'm still facing issues. While it's generally working I have problems with some apps. : : : Additionally in my system logs I can see: & are both working. My relevant config: I also tried using an overlay to apply the new meson flags from overlay: Is there anything else I need to set up?
also fails with
I have a very similar setup as and am experiencing precisely the same errors. I'm not sure whether it's an issue with gnome, my particular config, or what. Things work fine when running in an X session.
:thinking: I don't see anything missing with your config . I have updated my config to and removed the overlay. and are producing the same errors, and chrome won't function properly unless started with and are working for me, as well as and and . Note: Seam is installed via but this should only be relevant for running games inside steam, not steam itself.


Question: source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc"; }; <ins> # 'nvidia_x11' installs it's files to /run/opengl-driver/... environment.etc."egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; </ins> hardware.opengl.package = mkIf (!offloadCfg.enable) nvidia_x11.out; hardware.opengl.package32 = mkIf (!offloadCfg.enable) nvidia_x11.lib32; hardware.opengl.extraPackages = optional offloadCfg.enable nvidia_x11.out;

I came here because I'm experiencing the same as and Can't launch Steam or Kitty under Wayland: nvidia: 470.42.01 xwayland: 21.1.2 Config is virtually identical to
I found this issue because I had the same problem as After reading , I tried to create a different file (listed in the end). And that solved my problem. With this file, I can open steam. However, alacritty still has an error. Maybe that relates to another . The cause of this problem is that even though both and packages provide , cannot be found without a json file. The says: So, maybe we should add a json file /usr/share/egl/eglexternalplatform.d /xxx.jsonnvidia-x11egl-waylandlibnvidia-egl-wayland.solibnvidia-egl-, gnome setting says my video card is "Unknown". In the end, I will post my related config:
I filed this issue to see if we can patch to look in the right place: If we can't get it to look in then we should probably just add the etc symlink in the nixos module so that this works correctly for end users out of the box. I'll send an initial PR shortly and will update it in that egl-wayland issue gets a useful answer (or if there's another way to patch a closed source SO that I'm not thinking of).
BTW, I can confirm the different results. When I override nvidia's with our "upstream" one, I get more info in , but I'm not sure if there are other functional differences. Not sure what I would've expected, but it nags me that there's a difference.
PR:
Interesting, there IS a way to override the egl_externaplatform search path(s):
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
would this still be an issue after ?
I think it needs and
I am taking over as I've been using that setup as a daily driver and have a rough working understanding of the pieces fitting together. And to confirm, the general problem here, that is addressed in , is EGLStreams working in Wayland environment with the NVIDIA driver (aka, it doesn't now because we don't "wire up" NVIDIA's egl driver per egl-wayland's expectations).


Question: source = "${nvidia_x11.bin}/share/nvidia/nvidia-application-profiles-rc"; }; <ins> # 'nvidia_x11' installs it's files to /run/opengl-driver/... environment.etc."egl/egl_external_platform.d".source = "/run/opengl-driver/share/egl/egl_external_platform.d/"; </ins> hardware.opengl.package = mkIf (!offloadCfg.enable) nvidia_x11.out; hardware.opengl.package32 = mkIf (!offloadCfg.enable) nvidia_x11.lib32; hardware.opengl.extraPackages = optional offloadCfg.enable nvidia_x11.out;

That is pretty tangential to NVIDIA having a driver that supports GBM allocation and "wiring it up" (an extra piece included in ), and it being discoverable (whatever I send to replace ). Hope that helps.
Also, to reiterate, is good to merge independently on it's own and will resolve this issue. Separately, a replacement for will be necessary for the ideal Sway scenario without users having to set an extra env var.
I thought the point of the new Nvidia driver was to finally move away from EGLStreams? Is EGLStreams used by the new stable driver at all?
I don't know? It doesn't really matter, we should still fix it? Like, the fundamental issue is that we're simply not installing the Nvidia driver correctly for NixOS when it comes to these important configuration JSON files. Plus, it's not like everything is going to immediately switch to GBM, drop EGL, know about the env var, on and on. That, and the wiring for GBM is in that PR and I'm not splitting them apart at the current merge rate.


Question: imports = [ (mkRenamedOptionModule [ "networking" "networkmanager" "packages" ] <del> [ "networking" "networkmanager" "plugins" ]) (mkRenamedOptionModule [ "networking" "networkmanager" "useDnsmasq" ] [ "networking" "networkmanager" "dns" ]) </del> <ins> [ "networking" "networkmanager" "plugins" ] ) (mkRenamedOptionModule [ "networking" "networkmanager" "useDnsmasq" ] [ "networking" "networkmanager" "dns" ] ) (mkRemovedOptionModule [ "networking" "networkmanager" "extraConfig" ] '' This option was removed in favour of `networking.networkmanager.settings`, which accepts structured nix-code equivalent to the ini and allows for overriding settings. Example patch: ```patch networking.networkmanager = { -    extraConfig = ''' -      [main] -      no-auto-default=* -    ''' +    extraConfig.main.no-auto-default = "*"; }; ``` '' ) </ins> (mkRemovedOptionModule [ "networking" "networkmanager" "enableFccUnlock" ] '' This option was removed, because using bundled FCC unlock scripts is risky, might conflict with vendor-provided unlock scripts, and should

Describe the bug NetworkManager is a particularly important component and we don't have any tests for it that could block a channel advance. In particular, a change can happen on nixos-unstable leaving users without functioning networking, and while rollbacks are possible it isn't an excuse to allow that to reach production systems. NixOS doesn't produce either. Manual testing is also cumbersome if we want to make a new stable release. Upstream NetworkManager does have some integration testing but obviously not useful to us. I think to start, if we at least had a test that verifies the services start without issues would be great.
Agreed. While developing tests for the multipath TCP module I was surprised to see no networkmanager module. I had some difficulties with the nixos test infrastructure at first because the test infra will by default install a slirp interface () and it messed up the interface naming. Like I would clear but interfaces would still be named starting from instead of . Just thought I would mention it in case the brave soul writing the test is interested in multihoming. (but that's more a concern I have with the test infra).
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . 3. Ask on the on .
Bleh.
I marked this as stale due to inactivity. →
consequences of our inactions


Question: ++ lib.optional perlBindings perl ++ lib.optional saslSupport sasl; <del> patches = [ ./apr-1.patch ]; </del> <ins> patches = [ ./apr-1.patch ] ++ extraPatches; </ins> # We are hitting the following issue even with APR 1.6.x # -> https://issues.apache.org/jira/browse/SVN-4813

, CVSSv3=7.5 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc Cc


Question: import json import os <ins> import sys </ins> from pathlib import Path XDG_CONFIG_HOME = os.environ.get("XDG_CONFIG_HOME") or os.path.join(

Discord's package has a script which disables breaking updates, by looking and modifying the file. This script breaks if said exists but is empty (fails to load the JSON object) For some reason all values in this file cleared to me and I encountered this issue. (tested on NixOS 22.11 but the script hasn't changed in master) Steps to reproduce the behavior: discord discord should not launch at all (silently, unless launched from a terminal) should handle the exception which arises from this issue. N/A Some logs of when this happens: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
Hmm, interesting that Discord doesn't launch at all. This is a pretty simple fix though, Or something like that (Now that I think about it, if the doesn't exist yet, the script could create it)
Tangentally related: I installed discord on a new machine, and the disable breaking updates script didn't appear to have any effect until I created an empty containing just . There were other files in , but not . Creating that would be nice. Also, the only real indication that it was missing is that when I ran from a terminal, the first line of the output was . This is quite easy to miss because it's at the top of the output, so maybe it would be good to show these errors in a dialog or something similar.
I'm surprised this is even in tree - I don't think we should be changing program behavior - especially when you're calling it . I doubt the majority of the users even knew this was happening outside of those involved in PRs for nixpkgs. This is a matter of convenience like stated in the script that has a trade off causing a degradation in the security of the application - causing users to not update - relying on maintainers to do it. Please create a separate package for this at the same time when fixing this - call it whatever - just not . Or enclose it in an arg that is disabled by default.
I hit this same issue and adding an with contents got it running for me as well.
Thanks for opening an issue and describing the fix. This broke for me too and it took me a while to figure out why ...
This issue has been mentioned on NixOS Discourse. There might be relevant details there:


Question: license = licenses.lgpl21Plus; platforms = lib.platforms.linux; maintainers = [ ]; <ins> knownVulnerabilities = [ "CVE-2020-35476" # https://github.com/OpenTSDB/opentsdb/issues/2051 ]; </ins> }; }

, CVSSv3=9.8 (nixos-20.09, nixos-unstable) Scanned versions: nixos-20.09: ; nixos-unstable: . Cc


Question: # tesseract & leptonica. ++ lib.optionals enableTesseract [ tesseract leptonica ] ++ lib.optional enableTbb tbb <del> ++ lib.optional enableCuda cudatoolkit </del> ++ lib.optionals stdenv.isDarwin [ bzip2 AVFoundation Cocoa VideoDecodeAcceleration ] ++ lib.optionals enableDocs [ doxygen graphviz-nox ]; <del> propagatedBuildInputs = lib.optional enablePython pythonPackages.numpy; </del> <ins> propagatedBuildInputs = lib.optional enablePython pythonPackages.numpy ++ lib.optional enableCuda cudatoolkit; </ins> nativeBuildInputs = [ cmake pkg-config unzip ];

qimgv fails to build when . Steps to reproduce the behavior: No build errors. N/A. N/A. Maintainer information:
I am working on a patch to OpenCV to fix this issue correctly. In the meantime, you can replace with and it will build and operate properly. On my system I also had to add to to stop it crashing when I tried to open a file dialog but maybe that is just because I run Nix on Ubuntu instead of NixOS.


Question: "ftp://ftp.freedesktop.org/pub/mesa/${version}/mesa-${version}.tar.xz" "ftp://ftp.freedesktop.org/pub/mesa/older-versions/${branch}.x/${version}/mesa-${version}.tar.xz" ]; <del> sha256 = "08c118j440xpfbjjxmwzm6dfnv4y35q540mmzkchhpbwx89lczxd"; </del> <ins> sha256 = "0zd6skf9qcwlk1k1ljgwijwlyz5si3pgi0h97gd6kkivm7a4y43p"; </ins> }; # TODO: #  revive ./dricore-gallium.patch when it gets ported (from Ubuntu), as it saved #  ~35 MB in $drivers; watch https://launchpad.net/ubuntu/+source/mesa/+changelog patches = [ <del> # fixes pkgsMusl.mesa build </del> <ins> # To fix flickering on Intel GPUs (iris), see https://github.com/NixOS/nixpkgs/issues/153377: </ins> (fetchpatch { <del> url = "https://raw.githubusercontent.com/void-linux/void-packages/b9f58f303ae23754c95d5d1fe87a98b5a2d8f271/srcpkgs/mesa/patches/musl.patch"; sha256 = "sha256-Jyl7ILLhn8hBJG7afnEjE8H56Wz/1bxkvlqfrXK5U7I="; </del> <ins> url = "https://gitlab.freedesktop.org/mesa/mesa/-/commit/07dc3d4238e57901ccf98e0b506d9aad2c86b9d9.diff"; sha256 = "sha256-3fa1qHJes3x1/iXsxfjgy9HnEGlOyFtJatSkU1a3XDI="; </ins> }) <ins> # fixes pkgsMusl.mesa build ./musl.patch </ins> (fetchpatch { url = "https://raw.githubusercontent.com/void-linux/void-packages/b9f58f303ae23754c95d5d1fe87a98b5a2d8f271/srcpkgs/mesa/patches/musl-endian.patch"; sha256 = "sha256-eRc91qCaFlVzrxFrNUPpAHd1gsqKsLCCN0IW8pBQcqk=";

Mesa 21.3.2 present in is causing , and they point to , not yet fixed as of now. Reverting to nixos-unstable to Mesa 21.2.6 updates fixes the issue. Steps to reproduce the behavior: sure you're using Intel GPU nixos channel to No flickering should happen on the application screen. Mesa bug report has a video demonstrating the issue. If applicable, add screenshots to help explain your problem. cc: Please run and paste the result.
According to the bug report this seems to affect at least Blender as well. Anyway, we can leave this issue open for a while (in case it helps users to figure this out) but I don't think there's anything actionable for Nixpkgs (it's an upstream bug and we simply have to wait until a fix is released via a new version). It looks like the patch from should be submitted formally via a PR so that it might get included in Mesa 21.3.4.
This is also happening on qutebrowser for me, but only on the wayland backend. I have a temporary fix to just launch with , but this obviously disables the hardware. Works fine though so far for just browsing and work stuff, at least until a proper fix is merged.
It's unlikely that the patch will be applied for 21.3.4 (as no one filed a MR for it so far), should we apply it downstream?
I'm seeing this in qutebrowser as well (non-wayland)
I'd prefer to avoid applying a patch that hasn't been reviewed upstream.
+1 for what said. Luckily a developer from Intel started looking into this so let's see how things will develop: Ideally a patch will be ready for 21.3.4 but the release might happen in two days (unless it gets delayed) so it'll indeed be close (but we'll of course re-evaluate our options once the release is out).
Unfortunately it was indeed too close for the patch to land in Mesa 21.3.4. However, now there's at least an alternative patch from Paulo Zanoni (the Intel developer) and Giuseppe Ghibò (author of the other patch) and others confirmed that it's working: I've included that patch in Does someone have time to test it () and report if it indeed fixes the issues?


Question: "ftp://ftp.freedesktop.org/pub/mesa/${version}/mesa-${version}.tar.xz" "ftp://ftp.freedesktop.org/pub/mesa/older-versions/${branch}.x/${version}/mesa-${version}.tar.xz" ]; <del> sha256 = "08c118j440xpfbjjxmwzm6dfnv4y35q540mmzkchhpbwx89lczxd"; </del> <ins> sha256 = "0zd6skf9qcwlk1k1ljgwijwlyz5si3pgi0h97gd6kkivm7a4y43p"; </ins> }; # TODO: #  revive ./dricore-gallium.patch when it gets ported (from Ubuntu), as it saved #  ~35 MB in $drivers; watch https://launchpad.net/ubuntu/+source/mesa/+changelog patches = [ <del> # fixes pkgsMusl.mesa build </del> <ins> # To fix flickering on Intel GPUs (iris), see https://github.com/NixOS/nixpkgs/issues/153377: </ins> (fetchpatch { <del> url = "https://raw.githubusercontent.com/void-linux/void-packages/b9f58f303ae23754c95d5d1fe87a98b5a2d8f271/srcpkgs/mesa/patches/musl.patch"; sha256 = "sha256-Jyl7ILLhn8hBJG7afnEjE8H56Wz/1bxkvlqfrXK5U7I="; </del> <ins> url = "https://gitlab.freedesktop.org/mesa/mesa/-/commit/07dc3d4238e57901ccf98e0b506d9aad2c86b9d9.diff"; sha256 = "sha256-3fa1qHJes3x1/iXsxfjgy9HnEGlOyFtJatSkU1a3XDI="; </ins> }) <ins> # fixes pkgsMusl.mesa build ./musl.patch </ins> (fetchpatch { url = "https://raw.githubusercontent.com/void-linux/void-packages/b9f58f303ae23754c95d5d1fe87a98b5a2d8f271/srcpkgs/mesa/patches/musl-endian.patch"; sha256 = "sha256-eRc91qCaFlVzrxFrNUPpAHd1gsqKsLCCN0IW8pBQcqk=";

Thanks a lot for putting together a fix! I'm happy to test. Could you confirm I understood the instructions correctly? 1) integrate the code from the above PR into my nixpkgs tree. 2) put the following into my nixos config: 3) replace with the path to my nixpkgs tree. 4) run Did I get that right?
It's the easiest if you use a separate/dedicated Nixpkgs tree for Mesa ( in the example). That way you don't have to rebuild a lot of other packages (which would most likely still take way too long). You can also cherry-pick the commit to (I'd recommend doing that) which saves additional rebuilds (I only tested it that way so no idea how many many builds are currently cached for staging-next). The rest looks fine. And thanks in advance :)
It works like a charm. Thanks
Seems like this wasn't closed automatically once landed in master. Should be fixed now. And upstream merged the required patches in the meantime (s. note in ). And thanks for testing the fix and :)


Question: Xaw3d ghostscriptX perl <del> ] ++ stdenv.lib.optionals stdenv.isDarwin [ </del> pkgconfig <ins> ] ++ stdenv.lib.optionals stdenv.isDarwin [ </ins> libiconv ];

gv crashes with a segmentation fault immediately upon starting, before a window is visible. This happens even with an empty dummy document (created using latex and pdf2ps). For ease of reproducibility, you can find it . $ nix-shell -p gv [nix-shell:~]$ gv Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Thanks for merging! Glad that this is fixed. :-)


Question: <del> { stdenv, fetchurl, makeWrapper, jre, callPackage }: let dotty-bare = callPackage ./dotty-bare.nix { inherit stdenv fetchurl makeWrapper jre; }; in stdenv.mkDerivation { pname = "dotty"; inherit (dotty-bare) version; dontUnpack = true; installPhase = '' mkdir -p $out/bin ln -s ${dotty-bare}/bin/scalac $out/bin/scalac ln -s ${dotty-bare}/bin/scaladoc $out/bin/scaladoc ln -s ${dotty-bare}/bin/scala $out/bin/scala ln -s ${dotty-bare}/bin/common $out/bin/common ''; inherit (dotty-bare) meta; } </del>

Project description Scala 3 is more than a year old. It would be nice to have it packaged in nixpkgs as well. Maybe it is, but I couldn't find it under "scala-3" or respective versions. Metadata homepage URL: https://scala- source URL: license: Apache-2.0 License platforms: unix, linux, darwin, ...
is already packaged.
Indeed: the Scala 3 compiler started out under the codename 'dotty', and that's how it was packaged initially in nixpkgs. Now that dotty has become the 'official' scala 3 compiler (see also ), we should probably rename the package to as well? /cc
Feel free to update, rename and alias the old name :) Maybe should point at and can be


Question: ("generators.mkValueStringDefault: " + "${t} not supported: ${toPretty {} v}"); in   if isInt      v then toString v <ins> # convert derivations to store paths else if lib.isDerivation v then toString v </ins> # we default to not quoting strings else if isString   v then v # isString returns "1", which is not a good default

hangs when given a derivation because of infinite recursion either error or treat it as a string, which all other generators seem to do <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Maintainer information:
is there a context where a derivation would even be a valid input for this function? If not perhaps a simple fix would be to test for a derivation as input and simply throw a warning instead of continuing computation.
it shouldn't be possible to use derivation as a attrset for this function, but store paths could be useful which is similar to 's behavior
So this worked without error: I was able to reproduce the issue by just passing your example input above though, and in looks like nesting the derivation deeper also still causes the error. I guess we could map over the input at the start of the function and convert any unconverted derivations to strings before moving on. That should allow us to declare store paths and avoid this issue. Side note: you shouldn't have to restart your system to recover from the error condition; worked for me
I forgot SIGKILL existed. I removed the warning in the description
I have run into a very strange issue. I thought that the following patch should be all that is required to fix this: however even though I confirmed in repl that the conditional evaluates to false when passed `"${hello}", the codepath guarded by the conditional still seems to run anyway and fails with the following error: to add to the confusion, if I push the value one level deeper then it works fine:
i don't think ini support values at top level, or maybe its just the ini generator?
ah okay, then I guess my change is completely ineffective. I'll keep iterating :laughing: